Skip to content

Conversation

PeteBishwhip
Copy link
Member

This pull request includes several significant changes to the app/Support/GitHub.php file and the addition of a new Release class. These changes enhance the functionality for fetching and handling GitHub release data. Additionally, a new view template for displaying release notes has been added.

Enhancements to GitHub support:

  • app/Support/GitHub.php: Added imports for Release and Collection classes.
  • app/Support/GitHub.php: Modified latestVersion method to use the Release class and added a new releases method to fetch multiple releases.
  • app/Support/GitHub.php: Updated fetchLatestVersion to return an instance of Release and added a new fetchReleases method to handle multiple releases.

New Release class:

  • app/Support/GitHub/Release.php: Introduced a new Release class with properties and methods to handle GitHub release data, including conversion of URLs and user mentions to Markdown links.

New view template:

@PeteBishwhip
Copy link
Member Author

Here's a video of the new Release Notes page in action: https://screen.studio/share/hzB5lev6

@PeteBishwhip PeteBishwhip changed the title Feature/release notes Implement Release Notes page Mar 25, 2025
@SRWieZ SRWieZ self-requested a review March 26, 2025 13:52
Copy link
Member

@SRWieZ SRWieZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this feature. No release notes for mobile docs?

@PeteBishwhip
Copy link
Member Author

Like this feature. No release notes for mobile docs?

Could absolutely implement for mobile too. To do so would require a slight env update to include a GITHUB_TOKEN from @simonhamp so I can make a request to the relevant repo. I don't believe we currently authenticate GH API at all which I why I left it out for now.

@simonhamp - Would you like release notes for Mobile too? Happy to implement if you're happy to include a read-only GITHUB_TOKEN env var? :)

@simonhamp
Copy link
Member

We can leave it for mobile for now... I'm sharing publicly via Anystack - so we could link to that, but I wouldn't worry for now.

One thing I'd really like here is to reduce the URLs to PRs down to just their number, i.e. #123 and then make that the link, as right now it feels like there's a lot of repetition and it adds visual noise that makes the page feel a bit busy

simonhamp and others added 20 commits March 26, 2025 18:35
HassanZahirnia and others added 18 commits March 26, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants